New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: --message: add newlines before and after hr #3416

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
3 participants
@zmwangx
Contributor

zmwangx commented Nov 3, 2017

Without an empty line before the horizontal rule (---), "Created with brew bump-formula-pr." is treated as a setext header.

screen shot 2017-11-02 at 8 21 50 pm

screen shot 2017-11-02 at 8 21 56 pm

This only started happening very recently, and only to me it seems, for some reason? I didn't bother to check which commit resulted in this.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 3, 2017

Member

This only started happening very recently, and only to me it seems, for some reason? I didn't bother to check which commit resulted in this.

This may have been a GitHub rather than Homebrew change.

Member

MikeMcQuaid commented Nov 3, 2017

This only started happening very recently, and only to me it seems, for some reason? I didn't bother to check which commit resulted in this.

This may have been a GitHub rather than Homebrew change.

@zmwangx zmwangx referenced this pull request Nov 3, 2017

Closed

asciidoc 8.6.10 #20227

bump-formula-pr: --message: add newlines before and after hr
Without an empty line before the horizontal rule (---), "Created with `brew
bump-formula-pr`." is treated as a setext header.

The newline before the hr is not part of the heredoc because putting it in
would trip up Rubocop.
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 10, 2017

Member

Thanks again @zmwangx!

Member

MikeMcQuaid commented Nov 10, 2017

Thanks again @zmwangx!

@MikeMcQuaid MikeMcQuaid merged commit 441c212 into Homebrew:master Nov 10, 2017

2 of 3 checks passed

codecov/patch 0% of diff hit (target 69.19%)
Details
codecov/project 69.21% (+0.01%) compared to 4eeac6f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zmwangx zmwangx deleted the zmwangx:bump-formula-pr-fix-message branch Nov 10, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.