New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: unset SSL_CERT_FILE. #3417

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Member

MikeMcQuaid commented Nov 3, 2017

SSL_CERT_FILE can be incorrectly set by users or portable-ruby and screw with SSL downloads so unset it here.

CC @ilovezfs for thoughts on the approach

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Nov 3, 2017

Contributor

I wouldn't be surprised if we have people relying on being able to set that.

Contributor

ilovezfs commented Nov 3, 2017

I wouldn't be surprised if we have people relying on being able to set that.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 3, 2017

Member

@ilovezfs Fair point. If we break their workflows we may need to figure out a workaround for that (and env filtering isn't looking drastically far off at this point). I think we need to merge something similar to this to workaround the issue with our Ruby.

Member

MikeMcQuaid commented Nov 3, 2017

@ilovezfs Fair point. If we break their workflows we may need to figure out a workaround for that (and env filtering isn't looking drastically far off at this point). I think we need to merge something similar to this to workaround the issue with our Ruby.

@MikeMcQuaid MikeMcQuaid merged commit 265797b into Homebrew:master Nov 5, 2017

3 checks passed

codecov/patch 100% of diff hit (target 69.23%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +30.76% compared to c3006f0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:curl-unset-ssl-cert branch Nov 5, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.