New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor command handling code #3423

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Member

MikeMcQuaid commented Nov 5, 2017

Don’t rely on having external commands always present in the PATH in order to find them. Instead, provide an accessory method to Tap so they can be added and used when needed.

While we’re here, do some general refactoring and cleanup of the command code in these places.

Fixes #3421.

@MikeMcQuaid MikeMcQuaid referenced this pull request Nov 5, 2017

Closed

brew command has died for external taps #3421

4 of 4 tasks complete
Refactor command handling code
Don’t rely on having external commands always present in the PATH in
order to find them. Instead, provide an accessory method to Tap so
they can be added and used when needed.

While we’re here, do some general refactoring and cleanup of the
command code in these places.

@MikeMcQuaid MikeMcQuaid merged commit bef4213 into Homebrew:master Nov 5, 2017

3 checks passed

codecov/patch 88.46% of diff hit (target 69.22%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +19.23% compared to 5bf0584
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:commands-refactoring-fix branch Nov 5, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.