New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: use GitHub vars under env filter. #3427

Merged
merged 3 commits into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Member

MikeMcQuaid commented Nov 5, 2017

Ensure that the various variables are passed through and reset correctly. If we end up doing this in a bunch of places we may add some helpers to simplify this.

CC @ilovezfs who mentioned this.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Nov 5, 2017

Contributor

This will leak HOMEBREW_GITHUB_PASSWORD into brew config I think.

Contributor

ilovezfs commented Nov 5, 2017

This will leak HOMEBREW_GITHUB_PASSWORD into brew config I think.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 5, 2017

Member

This will leak HOMEBREW_GITHUB_PASSWORD into brew config I think.

@ilovezfs Good spot; will check and filter that.

Member

MikeMcQuaid commented Nov 5, 2017

This will leak HOMEBREW_GITHUB_PASSWORD into brew config I think.

@ilovezfs Good spot; will check and filter that.

Show outdated Hide outdated Library/Homebrew/extend/ENV.rb Outdated

MikeMcQuaid added some commits Nov 5, 2017

bump-formula-pr: use GitHub vars under env filter.
Ensure that the various variables are passed through and reset
correctly. If we end up doing this in a bunch of places we may add some
helpers to simplify this.

@MikeMcQuaid MikeMcQuaid merged commit 3ad4dca into Homebrew:master Nov 7, 2017

1 of 3 checks passed

codecov/patch 22.22% of diff hit (target 69.2%)
Details
codecov/project 69.17% (-0.03%) compared to 2ad1799
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:bump-formula-pr-env-filtering-github branch Nov 7, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.