New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew list 'filtered_list': pass explicit sort to handle APFS #3430

Merged
merged 2 commits into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@commitay
Member

commitay commented Nov 6, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

#3311

Follow up to #3316

Not sure if the sort needs to be applied to --pinned?

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Nov 7, 2017

Contributor

Damn, thought we'd caught the last of this fun.

Not sure if the sort needs to be applied to --pinned?

Yeah, it does 😓. Pinned a few things locally to check and:

qt
libressl
openssl
gnutls
Contributor

DomT4 commented Nov 7, 2017

Damn, thought we'd caught the last of this fun.

Not sure if the sort needs to be applied to --pinned?

Yeah, it does 😓. Pinned a few things locally to check and:

qt
libressl
openssl
gnutls

@commitay commitay changed the title from brew list --versions: pass explicit sort to handle APFS to brew list 'filtered_list': pass explicit sort to handle APFS Nov 7, 2017

@commitay

This comment has been minimized.

Show comment
Hide comment
@commitay

commitay Nov 7, 2017

Member

Thanks @DomT4!

Member

commitay commented Nov 7, 2017

Thanks @DomT4!

@MikeMcQuaid MikeMcQuaid merged commit b96ded7 into Homebrew:master Nov 7, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 69.21%)
Details
codecov/project 69.2% (-0.02%) compared to e300713
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 7, 2017

Member

Thanks again for your contribution to Homebrew, @commitay! Without people like you submitting PRs we couldn't run this project. You rock!

Member

MikeMcQuaid commented Nov 7, 2017

Thanks again for your contribution to Homebrew, @commitay! Without people like you submitting PRs we couldn't run this project. You rock!

@commitay commitay deleted the commitay:hash-order branch Nov 7, 2017

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Nov 7, 2017

Contributor

Thanks @DomT4!

Thank you for catching this! ❤️

Contributor

DomT4 commented Nov 7, 2017

Thanks @DomT4!

Thank you for catching this! ❤️

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.