New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor `DependsOn` with `DelegateClass`. #3432

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
2 participants
@reitermarkus
Member

reitermarkus commented Nov 6, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Needed for a cleaner implementation of #3258.

@Git-Jiro

This comment has been minimized.

Show comment
Hide comment
@Git-Jiro

Git-Jiro Nov 8, 2017

Contributor

@reitermarkus Who is going to approve your PR here?

Contributor

Git-Jiro commented Nov 8, 2017

@reitermarkus Who is going to approve your PR here?

@reitermarkus reitermarkus merged commit 5318907 into Homebrew:master Nov 10, 2017

3 checks passed

codecov/patch 100% of diff hit (target 69.21%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +30.78% compared to e300713
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:delegate-class branch Nov 10, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.