New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic: check if Xcode needs CLT installed. #3453

Merged
merged 2 commits into from Nov 18, 2017

Conversation

Projects
None yet
4 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Nov 17, 2017

Require the CLT on all but the latest version of macOS to avoid the continuous workarounds for SDK weirdness.

def latest_version?
version == latest_version
end

def prerelease?
# TODO: bump version when new OS is released

This comment has been minimized.

@ilovezfs

ilovezfs Nov 17, 2017

Contributor

probably should relocate the comment

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Nov 17, 2017

If you're using Xcode 10 on 10.13, and if we haven't bumped the latest_version to 10.14 yet because 10.14 is still pre-release, then I think the CLT needs to be required. The reason is that Xcode 10 will have the 10.14 SDK.

i.e. it's OK not to have CLT if your macOS version == macOS 10.13 && your Xcode version < Xcode 10

@@ -31,9 +31,17 @@ def full_version=(version)
@version = nil
end

def latest_version
Version.new "10.13"

This comment has been minimized.

@scpeters

scpeters Nov 17, 2017

Contributor

just checking that these versions won't ever have a patch number (10.13.1)?

This comment has been minimized.

@ilovezfs

ilovezfs Nov 17, 2017

Contributor

this gets compared to version not full_version so it should be ok I think

This comment has been minimized.

@scpeters

scpeters Nov 17, 2017

Contributor

yeah, it looks like version just has 10.minor

https://github.com/Homebrew/brew/blob/master/Library/Homebrew/os/mac.rb#L19-L21

thanks!

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:check_if_xcode_needs_clt_installed branch 2 times, most recently from cadf543 to ff4525a Nov 17, 2017

MikeMcQuaid added some commits Nov 17, 2017

diagnostic: check if Xcode needs CLT installed.
Require the CLT on all but the latest version of macOS to avoid the
continuous workarounds for SDK weirdness.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:check_if_xcode_needs_clt_installed branch from ff4525a to 2e1331c Nov 17, 2017

@MikeMcQuaid MikeMcQuaid merged commit 46bc5ec into Homebrew:master Nov 18, 2017

3 checks passed

codecov/patch 94.11% of diff hit (target 69.19%)
Details
codecov/project Absolute coverage decreased by -0.11% but relative coverage increased by +24.91% compared to 889fc81
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:check_if_xcode_needs_clt_installed branch Nov 18, 2017

@chrisfinazzo chrisfinazzo referenced this pull request Nov 18, 2017

Closed

"Xcode alone is not sufficient on Sierra" #3456

4 of 4 tasks complete
@zenspider

This comment has been minimized.

Copy link

zenspider commented Dec 7, 2017

The error message for this patch is terribly confusing and diverts people from the actual problem/solution.

brew: “Xcode alone is not sufficient on Sierra”

versus:

xcode-select: “command line tools are already installed”

There needs to be a proper distinction between "Xcode alone" vs "you don't have the latest SDK"...

Also, why do I need the latest SDK if I'm building for my current OS revision? Especially considering the SDK version doesn't determine build-ability? 99+% of the ports don't even touch the SDK, do they?

@zenspider zenspider referenced this pull request Dec 7, 2017

Closed

"Xcode alone is not sufficient on Sierra" (again) #3540

3 of 3 tasks complete
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Dec 8, 2017

The error message for this patch is terribly confusing

Original unedited message that I got emailed "The error message for this patch is terrible".

Also, why do I need the latest SDK if I'm building for my current OS revision? Especially considering the SDK version doesn't determine build-ability? 99+% of the ports don't even touch the SDK, do they?

I have no interest in answering your questions if you are going to be rude.

@Homebrew Homebrew locked and limited conversation to collaborators Dec 8, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.