New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optionally using Homebrew's curl #3482

Merged
merged 1 commit into from Nov 27, 2017

Conversation

Projects
None yet
4 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Nov 26, 2017

If HOMEBREW_FORCE_BREWED_CURL is set then allow it to be used instead of the system curl.

Closes #3480.

Allow optionally using Homebrew's curl
If `HOMEBREW_FORCE_BREWED_CURL` is set then allow it to be used instead
of the system `curl`.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:homebrew-curl branch from 55b1612 to a19d070 Nov 26, 2017

@MikeMcQuaid MikeMcQuaid referenced this pull request Nov 26, 2017

Closed

Use local Curl to support ProxyChains-NG #3480

5 of 5 tasks complete
@@ -110,16 +110,18 @@ then
# Don't change this from Mac OS X to match what macOS itself does in Safari on 10.12
HOMEBREW_OS_USER_AGENT_VERSION="Mac OS X $HOMEBREW_MACOS_VERSION"

# The system Curl is too old for some modern HTTPS certificates on
# older macOS versions.
printf -v HOMEBREW_MACOS_VERSION_NUMERIC "%02d%02d%02d" ${HOMEBREW_MACOS_VERSION//./ }
if [[ "$HOMEBREW_MACOS_VERSION_NUMERIC" -lt "101000" ]]
then
HOMEBREW_SYSTEM_CURL_TOO_OLD="1"

This comment has been minimized.

@reitermarkus

reitermarkus Nov 27, 2017

Member

Is this still used anywhere now?

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 27, 2017

Member

Yes: Library/Homebrew/extend/os/mac/development_tools.rb

@MikeMcQuaid MikeMcQuaid merged commit e41a0a3 into Homebrew:master Nov 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:homebrew-curl branch Nov 27, 2017

@MikeMcQuaid MikeMcQuaid referenced this pull request Nov 27, 2017

Closed

HOMEBREW_CURL env car bulldozed by brew.sh #2609

4 of 4 tasks complete
@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Nov 27, 2017

🎊

@miccal miccal referenced this pull request Nov 28, 2017

Closed

brew config: output of curl path and version #3433

4 of 4 tasks complete
@RandomDSdevel

This comment has been minimized.

Copy link
Contributor

RandomDSdevel commented Dec 6, 2017

@MikeMcQuaid, @ilovezfs, and/or @reitermarkus: Shouldn't HOMEBREW_FORCE_BREWED_CURL be documented in man brew now that this PR has added it? That's not addressed here.

MikeMcQuaid added a commit to MikeMcQuaid/brew that referenced this pull request Dec 6, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.