Allow optionally using Homebrew's curl #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `HOMEBREW_FORCE_BREWED_CURL` is set then allow it to be used instead of the system `curl`.
MikeMcQuaid
force-pushed
the
homebrew-curl
branch
from
55b1612
to
a19d070
Compare
5 tasks
| @@ -110,16 +110,18 @@ then | |||
| # Don't change this from Mac OS X to match what macOS itself does in Safari on 10.12 | |||
| HOMEBREW_OS_USER_AGENT_VERSION="Mac OS X $HOMEBREW_MACOS_VERSION" | |||
|
|
|||
| # The system Curl is too old for some modern HTTPS certificates on | |||
| # older macOS versions. | |||
| printf -v HOMEBREW_MACOS_VERSION_NUMERIC "%02d%02d%02d" ${HOMEBREW_MACOS_VERSION//./ } | |||
| if [[ "$HOMEBREW_MACOS_VERSION_NUMERIC" -lt "101000" ]] | |||
| then | |||
| HOMEBREW_SYSTEM_CURL_TOO_OLD="1" | |||
There was a problem hiding this comment.
Is this still used anywhere now?
There was a problem hiding this comment.
Yes: Library/Homebrew/extend/os/mac/development_tools.rb
4 tasks
|
🎊 |
4 tasks
|
@MikeMcQuaid, @ilovezfs, and/or @reitermarkus: Shouldn't |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
HOMEBREW_FORCE_BREWED_CURLis set then allow it to be used instead of the systemcurl.Closes #3480.