New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added no_proxy to filtered env #3584

Merged
merged 2 commits into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@Quesar
Contributor

Quesar commented Dec 18, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

no_proxy was requested in #3500 but was not included in #3501
The additions of other proxy environment variables causes brew update to use proxy for a private tap host which causes the operation to fail.

@MikeMcQuaid
Member

MikeMcQuaid left a comment

Thanks for the PR! Please also document this in brew.1.md.erb (like http_proxy has been) and run brew man to generate the other files and commit them too.

@MikeMcQuaid MikeMcQuaid merged commit 426c998 into Homebrew:master Dec 19, 2017

3 checks passed

codecov/patch Coverage not affected when comparing b4d43e9...28a0e44
Details
codecov/project 70.16% remains the same compared to b4d43e9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Member

MikeMcQuaid commented Dec 19, 2017

Thanks for your first contribution to Homebrew, @Quesar! Without people like you submitting PRs we couldn't run this project. You rock!

@Quesar Quesar deleted the Quesar:fix-proxy-config branch Dec 19, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.