New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinstall/upgrade: stop unlinked kegs being sticky #3660

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jan 10, 2018

It's not possible to determine the difference between a non-keg-only keg that failed to link and one that wasn't linked by us intentionally.

To avoid additional complexity of storing this logic in another place let's back out this relatively new functionality; sticky keg-only links is a better and more desirable behaviour anyway.

reinstall/upgrade: stop unlinked kegs being sticky
It's not possible to determine the difference between a non-keg-only
keg that failed to link and one that wasn't linked by us intentionally.

To avoid additional complexity of storing this logic in another place
let's back out this relatively new functionality; sticky keg-only links
is a better and more desirable behaviour anyway.

@MikeMcQuaid MikeMcQuaid merged commit 427c6ce into Homebrew:master Jan 10, 2018

3 checks passed

codecov/patch 80% of diff hit (target 70.31%)
Details
codecov/project 70.33% (+0.01%) compared to b660106
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:unlink-keg-no-sticky branch Jan 10, 2018

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.