New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable and add more deprecations. #3694

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Member

MikeMcQuaid commented Jan 18, 2018

These have all been deprecated/compat for a while.

Disable and add more deprecations.
These have all been deprecated/compat for a while.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:more-odisabled branch from b717c74 to 77f1768 Jan 18, 2018

end

_to_s
end

This comment has been minimized.

@alyssais

alyssais Jan 18, 2018

Contributor

Module#prepend would probably be nicer than an aliasing hack.

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jan 18, 2018

Member

@alyssais Yeh, good call. I'm using this for now for consistency with the rest of compat but I'd ❤️ a refactoring PR after this to use Module#prepend everywhere instead.

@MikeMcQuaid MikeMcQuaid merged commit 9201fbd into Homebrew:master Jan 18, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:more-odisabled branch Jan 18, 2018

@alyssais alyssais referenced this pull request Jan 18, 2018

Merged

`prepend` instead of alias hacks for deprecations #3696

5 of 5 tasks complete

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.