New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap: don’t tap deprecated taps. #3747

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jan 29, 2018

These no longer have any files in them.

tap: don’t tap deprecated taps.
These no longer have any files in them.

@MikeMcQuaid MikeMcQuaid merged commit 701ecb4 into Homebrew:master Jan 30, 2018

2 of 3 checks passed

codecov/patch 0% of diff hit (target 70.35%)
Details
codecov/project 70.35% remains the same compared to 91f9802
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:no-tap-deprecated branch Jan 30, 2018

@sjackman

This comment has been minimized.

Copy link
Contributor

sjackman commented Feb 15, 2018

Tapping the empty tap is needed to provide access to tap_migrations.json so that brew install homebrew/science/bwa installs homebrew/core/bwa. Would you accept a PR to revert this change?

Current behaviour

❯❯❯ brew install homebrew/science/bwa
Error: homebrew/science was deprecated. This tap is now empty as all its formulae were migrated.

Expected behaviour

❯❯❯ brew install homebrew/science/bwa
Warning: homebrew/science was deprecated. This tap is now empty as all its formulae were migrated.
==> Tapping homebrew/science
Cloning into '/Users/sjackman/.homebrew/Homebrew/Library/Taps/homebrew/homebrew-science'...
Warning: Use bwa instead of deprecated homebrew/science/bwa
==> Downloading https://homebrew.bintray.com/bottles/bwa-0.7.17.el_capitan.bottle.tar.gz
Already downloaded: /Users/sjackman/Library/Caches/Homebrew/bwa-0.7.17.el_capitan.bottle.tar.gz
==> Pouring bwa-0.7.17.el_capitan.bottle.tar.gz
🍺  /usr/local/Cellar/bwa/0.7.17: 8 files, 534.2KB
@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Feb 15, 2018

I don't think we want formulae out in the wild still to be able to use

depends_on "homebrew/science/bwa"

successfully.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Feb 16, 2018

@sjackman I don't think so, sorry. I think the current error message is more helpful to users and will require them to perform the necessary updates.

@sjackman

This comment has been minimized.

Copy link
Contributor

sjackman commented Feb 16, 2018

This tap was deprecated on Jan 1 and became a hard error on Feb 6. I feel that a deprecation period is typically longer than a month, before the warning becomes a hard error. My opinion anyway. I don't feel super strong about this issue.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.