New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ALL_PROXY for brew #3751

Merged
merged 2 commits into from Feb 2, 2018

Conversation

Projects
None yet
3 participants
@xiehuc
Copy link
Contributor

xiehuc commented Jan 30, 2018

Signed-off-by: xiehuc xiehuc@gmail.com

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

i don't know why there just lack ALL_PROXY .

there a so many tutorial say ALL_PROXY to set socks5 proxy

Homebrew/legacy-homebrew#11114
https://stackoverflow.com/questions/37231204/osx-proxy-issue-with-homebrew-install
https://apple.stackexchange.com/questions/228865/how-to-install-an-homebrew-package-behind-a-proxy

Fixes #3752

add ALL_PROXY for brew
Signed-off-by: xiehuc <xiehuc@gmail.com>

@scpeters scpeters referenced this pull request Jan 30, 2018

Closed

whitelist variable ALL_PROXY #3752

4 of 4 tasks complete
@scpeters

This comment has been minimized.

Copy link
Contributor

scpeters commented Jan 30, 2018

#3752 mentions all_proxy as well

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Feb 1, 2018

@xiehuc

This comment has been minimized.

Copy link
Contributor

xiehuc commented Feb 1, 2018

no problem at all. i would update later. thank you.

@xiehuc

This comment has been minimized.

Copy link
Contributor

xiehuc commented Feb 1, 2018

@MikeMcQuaid done, @scpeters add all_proxy

@MikeMcQuaid MikeMcQuaid merged commit a44b21b into Homebrew:master Feb 2, 2018

3 checks passed

codecov/patch Coverage not affected when comparing c77cafc...3e6adb7
Details
codecov/project 70.33% remains the same compared to c77cafc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Feb 2, 2018

Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @xiehuc!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.