New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect bottle download strategy #3986

Merged
merged 1 commit into from Mar 25, 2018

Conversation

Projects
None yet
2 participants
@amancevice
Copy link
Contributor

amancevice commented Mar 25, 2018

Use ::detect method of DownloadStrategyDetector to detect download strategy of a bottle from its root_url.

This allows bottle root_urls to be s3:// style URLs and be handled by the S3DownloadStrategy without specifying :using =>

No tests were written as this method is tested elsewhere.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Detect bottle download strategy
Use ::detect method of DownloadStrategyDetector to detect download strategy of a bottle from its root_url.

This allows bottle root_urls to be s3:// style URLs and be handled by the S3DownloadStrategy without specifying ':using =>'
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Mar 25, 2018

Nice work again @amancevice!

@MikeMcQuaid MikeMcQuaid merged commit 6034caf into Homebrew:master Mar 25, 2018

3 checks passed

codecov/patch 100% of diff hit (target 70.13%)
Details
codecov/project 70.13% (+0%) compared to d9e3ff6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.