New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit (strict): check for build.with? dependencies. #4033

Merged
merged 1 commit into from Apr 8, 2018

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Apr 7, 2018

These don't behave as expected; depending on when and where in Homebrew (or even an installation process) these are evaluated they return different results. This means that sometimes these will be seen as dependencies and sometimes they will be ignored entirely by the DSL.

Instead :optional or :recommended dependencies should be used. We don't have a solution yet for grouping dependencies together but this is another case for removing more optional dependencies altogether (as there are no designs or proposed implementations).

audit: check for build.with? dependencies.
These don't behave as expected; depending on when and where in Homebrew
(or even an installation process) these are evaluated they return
different results. This means that sometimes these will be seen as
dependencies and sometimes they will be ignored entirely by the DSL.

Instead `:optional` or `:recommended` dependencies should be used. We
don't have a solution yet for grouping dependencies together but this is
another case for removing more optional dependencies altogether (as
there are no designs or proposed implementations).

@MikeMcQuaid MikeMcQuaid requested a review from ilovezfs Apr 8, 2018

@MikeMcQuaid MikeMcQuaid changed the title audit: check for build.with? dependencies. audit (strict): check for build.with? dependencies. Apr 8, 2018

@MikeMcQuaid MikeMcQuaid merged commit b584e24 into Homebrew:master Apr 8, 2018

1 of 3 checks passed

codecov/patch 50% of diff hit (target 70.18%)
Details
codecov/project 70.15% (-0.03%) compared to 427e39b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:audit-depend-if-build-with branch Apr 8, 2018

@MikeMcQuaid MikeMcQuaid removed the in progress label Apr 8, 2018

@lock lock bot added the outdated label May 8, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.