New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac/version: add symbol for macOS Mojave #4274

Merged
merged 2 commits into from Jun 5, 2018

Conversation

Projects
None yet
3 participants
@DomT4
Copy link
Contributor

DomT4 commented Jun 4, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Hope this addresses my sluggishness last year 馃槈.

@DomT4 DomT4 changed the title mac/version: add symbol for macOS mojave mac/version: add symbol for macOS Mojave Jun 4, 2018

@DomT4 DomT4 force-pushed the DomT4:new_macos branch from 6a3248c to 0c12ab5 Jun 4, 2018

@claui

claui approved these changes Jun 4, 2018

Copy link
Member

claui left a comment

Your version bumping skills have definitely improved 馃槃

@DomT4

This comment has been minimized.

Copy link
Contributor

DomT4 commented Jun 4, 2018

I think (IIRC) I've been involved in some part of adding support for new macOS versions to brew since Yosemite, so, gotta keep the streak alive 馃槅.

@mistydemeo mistydemeo merged commit 7d25300 into Homebrew:master Jun 5, 2018

3 checks passed

codecov/patch Coverage not affected when comparing b088302...9391ac0
Details
codecov/project 69.57% (+4.84%) compared to b088302
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mistydemeo

This comment has been minimized.

Copy link
Contributor

mistydemeo commented Jun 5, 2018

Thank you!

@DomT4 DomT4 deleted the DomT4:new_macos branch Jun 5, 2018

@DomT4

This comment has been minimized.

Copy link
Contributor

DomT4 commented Jun 5, 2018

Been a while since I last contributed to this side of Homebrew, but I keep drifting back from time to time heh. Thanks for the merge!

@lock lock bot added the outdated label Jul 5, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.