New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portable-ruby: respect HOMEBREW_BOTTLE_DOMAIN variable. #4389

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jun 29, 2018

This was requested in https://discourse.brew.sh/t/adding-additional-download-sources-to-homebrew/2446

With this change you can use e.g. Artifactory for Homebrew's portable ruby.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

portable-ruby: respect HOMEBREW_BOTTLE_DOMAIN variable.
This was requested in:
https://discourse.brew.sh/t/adding-additional-download-sources-to-homebrew/2446

With this change you can use e.g. Artifactory for Homebrew's portable
ruby.

@wafflebot wafflebot bot added the in progress label Jun 29, 2018

@MikeMcQuaid MikeMcQuaid merged commit 1bf3aac into Homebrew:master Jun 29, 2018

3 checks passed

codecov/patch 100% of diff hit (target 63.26%)
Details
codecov/project Absolute coverage decreased by -7.7% but relative coverage increased by +36.73% compared to 0d33aba
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:bintray-portable-ruby branch Jun 29, 2018

@wafflebot wafflebot bot removed the in progress label Jun 29, 2018

@lock lock bot added the outdated label Jul 29, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.