New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable more deprecations. #4392

Merged
merged 2 commits into from Jul 15, 2018

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jun 29, 2018

  • Turn more old odeprecated into odisabled
  • Remove more old odisabled
  • Remove code for older Ruby versions

This should not be merged until we are sure the next version will be 1.7.0.

CC cask folks for the @Homebrew/cask changes.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@@ -363,15 +349,6 @@ def make_relative_symlink(src)
File.symlink(src.relative_path_from(dirname), self)
end

unless method_defined?(:/)
def /(other)

This comment has been minimized.

@reitermarkus

reitermarkus Jun 30, 2018

Member

Where did this go?

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jul 1, 2018

Member

Ruby 2.3.3 always defines this method.

This comment has been minimized.

@reitermarkus
@@ -95,7 +95,6 @@ def parse
next if encoding.nil?

# use the specified encoding for the rest of the file
next unless String.method_defined?(:force_encoding)

This comment has been minimized.

@reitermarkus

reitermarkus Jun 30, 2018

Member

Don't change vendored code.

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jul 1, 2018

Member

Agreed.

# @private
alias old_ruby ruby
end

# Run the `ruby` Homebrew is using rather than whatever is in the `PATH`.
def ruby(*args)

This comment has been minimized.

@reitermarkus

reitermarkus Jun 30, 2018

Member

Seems like this isn't used anywhere. Should we deprecate this?

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jul 1, 2018

Member

Good idea!

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:more-deprecation-disabled branch from 7229ea1 to 6724191 Jul 1, 2018

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:more-deprecation-disabled branch 3 times, most recently from e0a6d70 to fd80b8a Jul 9, 2018

@MikeMcQuaid MikeMcQuaid referenced this pull request Jul 13, 2018

Merged

Fix Requirement mktemp calls. #30057

4 of 4 tasks complete

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:more-deprecation-disabled branch from fd80b8a to 48e2114 Jul 14, 2018

Disable more deprecations.
- Turn more old `odeprecated` into `odisabled`
- Remove more old `odisabled`
- Remove code for older Ruby versions

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:more-deprecation-disabled branch from 48e2114 to 4a5cf62 Jul 14, 2018

Move methods from FileUtils to Formula
These don't need to live on FileUtils and don't really make sense there
either.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:more-deprecation-disabled branch from 4a5cf62 to 256dfc1 Jul 14, 2018

@MikeMcQuaid MikeMcQuaid merged commit bd5131d into Homebrew:master Jul 15, 2018

1 of 3 checks passed

codecov/patch 57.89% of diff hit (target 69.65%)
Details
codecov/project 69.62% (-0.03%) compared to 526bece
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Jul 15, 2018

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:more-deprecation-disabled branch Jul 15, 2018

jonchang added a commit to jonchang/homebrew-science that referenced this pull request Jul 19, 2018

@jonchang jonchang referenced this pull request Jul 19, 2018

Merged

Update for deprecations #190

jonchang added a commit to brewsci/homebrew-science that referenced this pull request Jul 19, 2018

@lock lock bot added the outdated label Aug 14, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.