Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
brew.sh: Don't allow system tmp dirs as prefixes #4397
This explicitly forbids the use of the system's temporary directory as an installation prefix, as we perform checks against the temporary directory when doing binary relocation.
referenced this pull request
Jun 30, 2018
The underlying issue specifically affects HOMEBREW_TEMP regardless of whether it's the default /tmp or some other path (and if HOMEBREW_TEMP isn't /tmp then /tmp is unaffected) so I'm wondering if the check and the messaging should check the value of HOMEBREW_TEMP for a non-default value and handle that case correctly too.
Yeah, I'll update it to handle this. It gets a little complicated, though, thanks to the
Edit: Actually, I guess
Looks like the test failure is coming from
Any thoughts on how best to resolve this? I could add another environment variable allowing the behavior in the PR to be overridden for testing purposes, or change
Jul 3, 2018