New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-report: solicit donations. #4682

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Aug 14, 2018

This message will only be displayed once.

Fixes #4644.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

update-report: solicit donations.
This message will only be displayed once.

Fixes #4644.

# Consider the message possibly missed if not a TTY.
if $stdout.tty?
safe_system "git", "config", "--local", "--replace-all", "homebrew.donationmessage", "true"

This comment has been minimized.

@sjackman

sjackman Aug 14, 2018

Contributor

If never run on a TTY, for example in a non-interactive script, will this message be printed at every execution of brew?

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Aug 14, 2018

Member

Every execution of brew update: yes. That's the same with the analytics messaging.

@MikeMcQuaid MikeMcQuaid merged commit 0d81ad0 into Homebrew:master Aug 14, 2018

2 of 3 checks passed

codecov/patch 0% of diff hit (target 71.03%)
Details
codecov/project 71% (-0.04%) compared to 3e890c1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Aug 14, 2018

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:update-donations branch Aug 14, 2018

@lock lock bot added the outdated label Sep 13, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.