New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check version conflicts using linkage. #4762

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Aug 27, 2018

Instead of refusing to install software preemptively by assuming
multiple linkage to differing versions of the same library we now make
brew linkage --test verify that we don't have two versions of the
same library linked at the same time.

This will be considerably more permissive whilst checking the actual
problem that we're worried about.

CC @DomT4 as this will allow what you were doing in #4729.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Check version conflicts using linkage.
Instead of refusing to install software preemptively by assuming
multiple linkage to differing versions of the same library we now make
`brew linkage --test` verify that we don't have two versions of the
same library linked at the same time.

This will be considerably more permissive whilst checking the actual
problem that we're worried about.

@wafflebot wafflebot bot added the in progress label Aug 27, 2018

@MikeMcQuaid MikeMcQuaid merged commit 8aad63b into Homebrew:master Aug 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Aug 27, 2018

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Aug 27, 2018

Merging as CodeCov is temporarily broken.

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:version-conflicts-linkage branch Aug 27, 2018

@lock lock bot added the outdated label Sep 26, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.