Revert "Add $LOAD_PATH for RuboCop cops."
#4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
colindean
approved these changes
Sep 2, 2018
What? Can you give an example of what exactly should work? |
|
Install rubocop outside of Homebrew and run it on a formula. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4771
@reitermarkus Sorry, I didn't think about this before but this breaks one of the primary use-cases of our
rubocopintegration: being able to work with justrubocoploading just the cops outside of abrewcommand. A plainrubocopoutside of Homebrew should work on Homebrew formulae inside the taps directory withoutbrew style. I'm open to having a test added for this; I'm not quite sure what it would look like.