New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve writable directory handling #4844

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Sep 6, 2018

Consolidate the handling of which directories need to exist and which need to be writable. Additionally, add a fatal check for formula installations to ensure that any directories that need to be writable are so before attempting an installation.

Fixes #4626.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@wafflebot wafflebot bot added the in progress label Sep 6, 2018

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:improve-writable-directory-handling branch from f3a410a to 9083887 Sep 6, 2018

KEG_LINK_DIRECTORIES = %w[
bin etc include lib sbin share var Frameworks
].freeze
# TODO: remove when brew-test-bot no longer users this

This comment has been minimized.

@reitermarkus

reitermarkus Sep 6, 2018

Member

“uses”

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:improve-writable-directory-handling branch 3 times, most recently from 0cc1a94 to f6b8759 Sep 6, 2018

Improve writable directory handling
Consolidate the handling of which directories need to exist and which
need to be writable. Additionally, add a fatal check for formula
installations to ensure that any directories that need to be writable
are so before attempting an installation.

Fixes #4626.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:improve-writable-directory-handling branch from f6b8759 to 7615d3a Sep 6, 2018

@MikeMcQuaid MikeMcQuaid merged commit a2f5355 into Homebrew:master Sep 7, 2018

3 checks passed

codecov/patch 86.96% of diff hit (target 71.33%)
Details
codecov/project 71.36% (+0.03%) compared to 8778cc3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:improve-writable-directory-handling branch Sep 7, 2018

@wafflebot wafflebot bot removed the in progress label Sep 7, 2018

@fxcoudert

This comment has been minimized.

Copy link
Member

fxcoudert commented Sep 7, 2018

CI testbot is currently complaining on all builds with:

08:22:26 ==> brew doctor
08:22:29 ==> FAILED
08:22:29 Please note that these warnings are just used to help the Homebrew maintainers
08:22:29 with debugging if you file an issue. If everything you use Homebrew for is
08:22:29 working fine: please don't worry or file an issue; just ignore this. Thanks!
08:22:29 
08:22:29 Warning: The following directories are not writable by your user:
08:22:29 /usr/local/Caskroom
08:22:29 
08:22:29 You should change the ownership of these directories to your user.
08:22:29   sudo chown -R $(whoami) /usr/local/Caskroom

Might it be related to this PR?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Sep 7, 2018

@fxcoudert Addressed in
#4855

@DomT4 DomT4 referenced this pull request Sep 8, 2018

Closed

Homebrew doesn't like a missing /usr/local/Frameworks #31920

3 of 3 tasks complete

@lock lock bot added the outdated label Oct 7, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.