New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ActiveSupport Object#blank? and #present? #4902

Merged
merged 2 commits into from Sep 16, 2018

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Sep 14, 2018

This partially adds ActiveSupport (and Concurrent Ruby, a dependency) gems.

This adds some slight overhead (~10%) to loading global.rb but I think it's
probably worth it for us to be able to write better code while relying on
well-tested, widely used and understood libraries.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

MikeMcQuaid added some commits Sep 14, 2018

@wafflebot wafflebot bot added the in progress label Sep 14, 2018

@MikeMcQuaid MikeMcQuaid requested a review from reitermarkus Sep 14, 2018

@reitermarkus reitermarkus merged commit dfb6ada into Homebrew:master Sep 16, 2018

2 of 3 checks passed

codecov/patch 50% of diff hit (target 71.18%)
Details
codecov/project 71.18% (+<.01%) compared to 04e3344
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Sep 16, 2018

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:active-support-blank branch Sep 16, 2018

@lock lock bot added the outdated label Oct 16, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.