New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ActiveSupport Hash#deep_merge #4912

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Sep 16, 2018

And delete our own implementation.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@wafflebot wafflebot bot added the in progress label Sep 16, 2018

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:activesupport-hash-deep-merge branch from bb537d4 to bb3e07f Sep 16, 2018

Use ActiveSupport Hash#deep_merge
And delete our own implementation.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:activesupport-hash-deep-merge branch from bb3e07f to 0c63318 Sep 17, 2018

@MikeMcQuaid MikeMcQuaid merged commit 4d1de33 into Homebrew:master Sep 18, 2018

2 of 3 checks passed

codecov/patch 50% of diff hit (target 71.19%)
Details
codecov/project 71.21% (+0.02%) compared to 2d8d412
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:activesupport-hash-deep-merge branch Sep 18, 2018

@wafflebot wafflebot bot removed the in progress label Sep 18, 2018

MikeMcQuaid added a commit to MikeMcQuaid/homebrew-test-bot that referenced this pull request Sep 18, 2018

MikeMcQuaid added a commit to MikeMcQuaid/homebrew-test-bot that referenced this pull request Sep 18, 2018

@lock lock bot added the outdated label Oct 18, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.