New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ActiveSupport File.atomic_write #4913

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Sep 16, 2018

And delete our own implementation.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:activesupport-file-atomic branch 2 times, most recently from 83af7ea to 2b52fc6 Sep 17, 2018

Use ActiveSupport File.atomic_write
nd delete our own implementation.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:activesupport-file-atomic branch from 2b52fc6 to ead23d1 Sep 18, 2018

@MikeMcQuaid MikeMcQuaid merged commit c1e26f5 into Homebrew:master Sep 18, 2018

3 checks passed

codecov/patch 100% of diff hit (target 71.19%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +28.81% compared to 4d1de33
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:activesupport-file-atomic branch Sep 18, 2018

@wafflebot wafflebot bot removed the in progress label Sep 18, 2018

@lock lock bot added the outdated label Oct 18, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.