New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: disallow `devel` specs in `core` #5086

Merged
merged 1 commit into from Oct 20, 2018

Conversation

Projects
None yet
2 participants
@commitay
Copy link
Contributor

commitay commented Oct 11, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

See discussion in #5060 (comment)

@commitay

This comment has been minimized.

Copy link
Contributor

commitay commented Oct 20, 2018

Devel specs have been removed or have open PRs to be removed, merging.

@commitay commitay merged commit bcd1056 into Homebrew:master Oct 20, 2018

3 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@commitay commitay deleted the commitay:no-devel-specs branch Oct 20, 2018

@commitay

This comment has been minimized.

Copy link
Contributor

commitay commented Oct 21, 2018

All devel specs have been removed.

@commitay commitay referenced this pull request Oct 23, 2018

Closed

vault 0.11.4 #32650

4 of 4 tasks complete

commitay referenced this pull request in Homebrew/homebrew-core Oct 24, 2018

commitay referenced this pull request in Homebrew/homebrew-core Oct 31, 2018

@lock lock bot added the outdated label Nov 20, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.