New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gist-logs to create private gist (vs. public) #5089

Merged
merged 1 commit into from Oct 21, 2018

Conversation

Projects
None yet
6 participants
@JBallin
Copy link
Contributor

JBallin commented Oct 11, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Gists don't need to be listed on a user's page because they provide the direct link in their issues.

'Create Gist' GitHub API docs.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Oct 12, 2018

What are the downsides of it being public?

@JBallin

This comment has been minimized.

Copy link
Contributor

JBallin commented Oct 12, 2018

Privacy and keeping my public gists clean. What's the downside of private?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Oct 13, 2018

@Homebrew/maintainers any thoughts on this?

What's the downside of private?

It's a change from the status quo. The change needs justified rather than the current behaviour.

@SMillerDev

This comment has been minimized.

Copy link
Contributor

SMillerDev commented Oct 14, 2018

If it doesn't change anything in the behavior I'm fine with it.

@javian

This comment has been minimized.

Copy link
Member

javian commented Oct 14, 2018

One privacy issue I can see at the moment is that if you install in a non-default location and put the root directory inside your home directory you would potentially expose your username through any exposed paths. If you posted in an issue it would of course be visible there anyway but then it would be a more conscious act.

It would also not expose data for people that typed the command without knowing the consequences.

@woodruffw

This comment has been minimized.

Copy link
Member

woodruffw commented Oct 14, 2018

Does making the gists private by default mean that search engines won't index them? If so, I'm 👍 on the status quo -- I've fixed more than one problem in the past by going through someone else's logs after finding them on Google. Otherwise, I'm fine with this change.

@JBallin

This comment has been minimized.

Copy link
Contributor

JBallin commented Oct 15, 2018

@woodruffw looks like private gists are NOT indexed.

Private gists use Google's robots meta tag:

$ curl $PRIVATE_GIST_URL | grep robots
<meta name="robots" content="noindex, follow" />

$ curl $PUBLIC_GIST_URL | grep robots

Another option is a --private flag.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Oct 15, 2018

Another option is a --private flag.

As long as this isn't the default and is documented: this seems like a better option to me.

@JBallin JBallin force-pushed the JBallin:private-gist branch from d6cbf23 to e0d7c4a Oct 15, 2018

@JBallin

This comment has been minimized.

Copy link
Contributor

JBallin commented Oct 15, 2018

Sounds good! I can't complete this immediately, but will do it soon. Should I close the PR in the mean time so it's not in your queue?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Oct 15, 2018

No, it's fine to leave open 👍

Add --private flag to gist-logs
Co-Authored-By: JBallin <JBallin@users.noreply.github.com>

@JBallin JBallin force-pushed the JBallin:private-gist branch from aafecb7 to f10691b Oct 20, 2018

@MikeMcQuaid MikeMcQuaid merged commit 6ace80d into Homebrew:master Oct 21, 2018

3 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Oct 21, 2018

Thanks again @JBallin!

@JBallin JBallin deleted the JBallin:private-gist branch Oct 21, 2018

MikeMcQuaid added a commit to MikeMcQuaid/brew that referenced this pull request Oct 23, 2018

Update manpage
Pull in changes from
Homebrew/homebrew-services#174 and some missing
changes from Homebrew#5089.

@MikeMcQuaid MikeMcQuaid referenced this pull request Oct 23, 2018

Merged

Update manpage #5160

5 of 6 tasks complete

@lock lock bot added the outdated label Nov 20, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.