Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap in description of current behavior instead of 1.9.3 hack comment #5150

Merged
merged 2 commits into from Oct 23, 2018

Conversation

colindean
Copy link
Member

While working on f10691b, I noticed this odd comment and decided to investigate. I wasn't able to reproduce the undesirable behavior because I cannot get 1.8.7 to compile with rvm but I did notice through some testing that iTerm2 displays a lock character when echo mode is disabled.

My intent had been to remove this method because Homebrew has moved past a Ruby version that would necessitate the "hack" but this method's behavior is actually desirable today, so I changed the comment to remove the potential flag and instead left a comment explaining a good second reason for the method.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

While working on f10691b, I noticed this odd comment and decided to
investigate. I wasn't able to reproduce the undesirable behavior because
I cannot get 1.8.7 to compile with rvm but I did notice through some
testing that iTerm2 displays a lock character when echo mode is
disabled. My intent had been to remove this method because Homebrew has
moved past a Ruby version that would necessitate the "hack" but this
method's behavior is actually desirable today, so I changed the comment
to remove the potential flag and instead left a comment explaining
a good second reason for the method.
@@ -80,7 +80,7 @@ def brief_build_info(f)
s
end

# Hack for ruby < 1.9.3
# Causes some terminals to display secure entry indicators
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. a password-style prompt? If so might be nice to use the word "password" in here somewhere?

@MikeMcQuaid
Copy link
Member

Thanks again @colindean!

@MikeMcQuaid MikeMcQuaid merged commit fb020a9 into Homebrew:master Oct 23, 2018
@lock lock bot added the outdated PR was locked due to age label Nov 22, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants