New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #5169

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
5 participants
@sjackman
Copy link
Contributor

sjackman commented Oct 24, 2018

No description provided.

@sjackman sjackman self-assigned this Oct 24, 2018

@sjackman sjackman requested a review from MikeMcQuaid Oct 24, 2018

Show resolved Hide resolved Dockerfile
Show resolved Hide resolved Dockerfile Outdated

RUN apt-get update \
&& apt-get install -y --no-install-recommends bzip2 ca-certificates curl file fonts-dejavu-core g++ git locales make openssh-client patch sudo uuid-runtime \
&& rm -rf /var/lib/apt/lists/*

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Oct 24, 2018

Member

What's this for? If cleaning: is there an apt command that can be used instead?

This comment has been minimized.

@scpeters

scpeters Oct 24, 2018

Contributor

This is what they recommend as a best practice in the docker documentation. I'm not sure if there's an apt command that can be used instead; I've always seen it like this.

This comment has been minimized.

@sjackman

sjackman Oct 24, 2018

Contributor

I would have expected apt-get clean to have an option to remove /var/lib/apt/lists, but I was not able to find such an option. See https://linux.die.net/man/8/apt-get


RUN localedef -i en_US -f UTF-8 en_US.UTF-8 \
&& useradd -m -s /bin/bash linuxbrew \
&& echo 'linuxbrew ALL=(ALL) NOPASSWD:ALL' >>/etc/sudoers

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Oct 24, 2018

Member

Is this standard practise for Docker?

This comment has been minimized.

@scpeters

scpeters Oct 24, 2018

Contributor

I didn't see it recommended on the official docker website, but I see something similar here:

This comment has been minimized.

@sjackman

sjackman Oct 24, 2018

Contributor

Standard practice for Docker is to leave the user as root, but brew refuses to run as root.

Minor style point, I can instead put this file in /etc/sudoers.d/. Any preference?

This comment has been minimized.

@scpeters

scpeters Oct 25, 2018

Contributor

Minor style point, I can instead put this file in /etc/sudoers.d/. Any preference?

No preference from me; I defer.

Show resolved Hide resolved Dockerfile
@chdiza

This comment has been minimized.

Copy link
Contributor

chdiza commented Oct 24, 2018

I hope that this can instead be named .Dockerfile, so that users don't have this cluttering up the dir.

Same for the recently added azure thingy; can it be .azure-piplelines.yml instead?

The other CI/auxiliary support stuff in the root dir are all dotfiles: .travis.yml, .yardopts, .github, .editorconfig.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Oct 24, 2018

I hope that this can instead be named .Dockerfile, so that users don't have this cluttering up the dir.

Same for the recently added azure thingy; can it be .azure-piplelines.yml instead?

We're using the default names for both because almost all tooling expects them to have those names. Now that this stuff isn't in the /usr/local root there's not a strong argument to me for needing to hide things away in this repository compared to a normal one.

@sjackman sjackman force-pushed the sjackman:dockerfile branch from 3ecc26b to 05d28aa Oct 24, 2018

@sjackman sjackman force-pushed the sjackman:dockerfile branch from 05d28aa to f4e61bc Oct 24, 2018

@scpeters
Copy link
Contributor

scpeters left a comment

brew doctor is clean now; nice work

@sjackman

This comment has been minimized.

Copy link
Contributor

sjackman commented Oct 25, 2018

brew tests and brew test-bot will be clean after PR #5180.
@scpeters Care to review this PR for me? I'll merge this PR after that one, and then set up Docker Hub to build the image on each commit.

@scpeters

This comment has been minimized.

Copy link
Contributor

scpeters commented Oct 25, 2018

Sure, I'll review it in between meetings today.

@sjackman sjackman merged commit b0e3e73 into Homebrew:master Oct 25, 2018

3 checks passed

codecov/patch Coverage not affected when comparing a4c62d3...f4e61bc
Details
codecov/project 70.64% (+0.01%) compared to a4c62d3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sjackman sjackman deleted the sjackman:dockerfile branch Oct 25, 2018

@sjackman

This comment has been minimized.

Copy link
Contributor

sjackman commented Oct 25, 2018

Merged! I'll set up a Docker Hub build now.

@sjackman

This comment has been minimized.

Copy link
Contributor

sjackman commented Oct 25, 2018

@scpeters

This comment has been minimized.

Copy link
Contributor

scpeters commented Oct 26, 2018

nice work! I was just experimenting with it and noticed a problem with the python@2 formula. Should I report that as an issue at https://github.com/Linuxbrew/homebrew-core/issues ?

@sjackman

This comment has been minimized.

Copy link
Contributor

sjackman commented Oct 26, 2018

Yes, please!

@lock lock bot added the outdated label Nov 25, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.