New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/Maintainer-Guidelines: add mission. #5223

Merged
merged 1 commit into from Nov 2, 2018

Conversation

@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Oct 31, 2018

@zbeekman mentioned this would be good to add to the docs but didn't get around to it.

@Homebrew/maintainers any thoughts on this are welcome.


@@ -9,6 +9,10 @@ Maybe you were looking for the [Formula Cookbook](Formula-Cookbook.md)?

This document is current practice. If you wish to change or discuss any of the below: open a PR to suggest a change.

## Mission

Homebrew seeks to be the missing package manager for macOS. It's primary goal is to be useful. It should be as useful as possible to as many people as possible that we can maintain as a small group of volunteers to a commercially high standard. Where possible and sensible it should seek to use macOS features and blend in with the macOS and Apple ecosystem.

This comment has been minimized.

@vitorgalvao

vitorgalvao Oct 31, 2018

Member

It's → Its.

Suggested change Beta
Homebrew seeks to be the missing package manager for macOS. It's primary goal is to be useful. It should be as useful as possible to as many people as possible that we can maintain as a small group of volunteers to a commercially high standard. Where possible and sensible it should seek to use macOS features and blend in with the macOS and Apple ecosystem.
Homebrew seeks to be the missing package manager for macOS. Its primary goal is to be useful. It should be as useful as possible to as many people as possible that we can maintain as a small group of volunteers to a commercially high standard. Where possible and sensible it should seek to use macOS features and blend in with the macOS and Apple ecosystem.

This comment has been minimized.

@vitorgalvao

vitorgalvao Oct 31, 2018

Member

The third sentence reads weird to me. I understand the meaning, but I feel some non-native english speakers might be confused. It’s the “that” connector that’s tripping me up, I think.

Also, might it me wise to remove the “commercially”? On commercial apps support is supposed to always be nice, even if the customer is rude. Here we typically warn/ask users to be more civil and may even ban them if they’re irredeemably difficult.

This comment has been minimized.

@Moisan

Moisan Oct 31, 2018

Member

Non-native english speaker here. I am confused by the third sentence. How about
It should be as useful as possible to as many people as possible while being maintained by a small group of volunteers to a commercially high standard.

This comment has been minimized.

@zbeekman

zbeekman Oct 31, 2018

Member
Suggested change Beta
Homebrew seeks to be the missing package manager for macOS. It's primary goal is to be useful. It should be as useful as possible to as many people as possible that we can maintain as a small group of volunteers to a commercially high standard. Where possible and sensible it should seek to use macOS features and blend in with the macOS and Apple ecosystem.
Homebrew seeks to be the missing package manager for macOS. Its primary goal is to be useful. It should be as useful as possible to as many people as possible while remaining maintainable by a small group of volunteers to a commercially high standard. Where possible and sensible it should seek to use macOS features and blend in with the macOS and Apple ecosystem.

Native English speaker here, and, yes, I agree the third sentence needs re-wording. Sorry for dropping the ball on this @MikeMcQuaid and thanks for adding it!

@Moisan I've adapted your suggestion a bit
@vitorgalvao I've included your suggested edit in my suggested edit

Show resolved Hide resolved docs/Maintainer-Guidelines.md Outdated

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:mission branch from 3240541 to 982fc5d Oct 31, 2018

Show resolved Hide resolved docs/Maintainer-Guidelines.md Outdated
Show resolved Hide resolved docs/Maintainer-Guidelines.md Outdated

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:mission branch from 982fc5d to 7601634 Nov 2, 2018

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Nov 2, 2018

I believe I'd addressed pretty much all feedback here so 🚢. Thanks everyone for the help and feedback ❤️

@claui

claui approved these changes Nov 2, 2018

@MikeMcQuaid MikeMcQuaid merged commit 66d78f7 into Homebrew:master Nov 2, 2018

3 checks passed

codecov/patch Coverage not affected when comparing a6b17ab...7601634
Details
codecov/project 70.62% (+0.01%) compared to a6b17ab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:mission branch Nov 2, 2018

@lock lock bot added the outdated label Dec 2, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Dec 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.