New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinstall: Use CLI::Parser to parse args #5274

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@GauthamGoli
Copy link
Member

GauthamGoli commented Nov 7, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#1860

@MikeMcQuaid
Copy link
Member

MikeMcQuaid left a comment

This will likely break some expectations about reinstall accepting arguments but given that's undocumented behaviour I'm happy for this to be merged as-is 👍

@GauthamGoli GauthamGoli merged commit d18c201 into Homebrew:master Nov 8, 2018

3 checks passed

codecov/patch 100% of diff hit (target 70.62%)
Details
codecov/project 70.63% (+0.01%) compared to 0722d81
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@spl spl referenced this pull request Nov 13, 2018

Closed

reinstall no longer accepts --verbose #5319

4 of 5 tasks complete

justinmk added a commit to justinmk/neovim that referenced this pull request Nov 20, 2018

CI/Travis/macOS: Fix "brew reinstall" invocation
"-s" is "--build-from-source", an option to `brew install`.  This was
never a documented option per `brew help reinstall`.  It's not clear why
we were using this option, but it now fails the CI build.

ref Homebrew/brew#5274
ref Homebrew/brew#1656

justinmk added a commit to neovim/neovim that referenced this pull request Nov 20, 2018

CI/Travis/macOS: Fix "brew reinstall" invocation (#9259)
"-s" is "--build-from-source", an option to `brew install`.  This was
never a documented option per `brew help reinstall`.  It's not clear why
we were using this option, but it now fails the CI build.

ref Homebrew/brew#5274
ref Homebrew/brew#1656

justinmk added a commit to neovim/bot-ci that referenced this pull request Nov 22, 2018

Travis/macOS: Fix "brew reinstall" invocation
ref neovim/neovim#9259

"-s" is "--build-from-source", an option to `brew install`.  This was
never a documented option per `brew help reinstall`.  It's not clear why
we were using this option, but it now fails in the current Homebrew.

ref Homebrew/brew#5274
ref Homebrew/brew#1656

@lock lock bot added the outdated label Dec 8, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.