New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: don't automatically upgrade from another tap. #5291

Merged
merged 1 commit into from Nov 11, 2018

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Nov 10, 2018

Rather than automatically upgrading a formula from one tap to a formula from another when specified as a dependency require a manual intervention to be clear that's the user's intention.

Fixes #5224

CC @blogabe

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

formula_installer: don't automatically upgrade from another tap.
Rather than automatically upgrading a formula from one tap to a formula
from another when specified as a dependency require a manual
intervention to be clear that's the user's intention.

@MikeMcQuaid MikeMcQuaid merged commit 85da607 into Homebrew:master Nov 11, 2018

2 of 3 checks passed

codecov/patch 0% of diff hit (target 71.14%)
Details
codecov/project 71.13% (-0.01%) compared to a8aed38
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:no_tap_auto_upgrade branch Nov 11, 2018

@lock lock bot added the outdated label Dec 11, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.