Skip to content

formula_installer: don't automatically upgrade from another tap. - #5291

Merged
MikeMcQuaid merged 1 commit into
Homebrew:masterfrom
MikeMcQuaid:no_tap_auto_upgrade
Nov 11, 2018
Merged

MikeMcQuaid merged 1 commit into
Homebrew:masterfrom
MikeMcQuaid:no_tap_auto_upgrade

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Nov 10, 2018 •

Copy link
Copy Markdown
Member

Rather than automatically upgrading a formula from one tap to a formula from another when specified as a dependency require a manual intervention to be clear that's the user's intention.

Fixes #5224

CC @blogabe

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Rather than automatically upgrading a formula from one tap to a formula
from another when specified as a dependency require a manual
intervention to be clear that's the user's intention.
@MikeMcQuaid
MikeMcQuaid merged commit 85da607 into Homebrew:master Nov 11, 2018
@MikeMcQuaid
MikeMcQuaid deleted the no_tap_auto_upgrade branch November 11, 2018 09:54
@lock lock Bot added the outdated PR was locked due to age label Dec 11, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant