Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottle: Ignore matches to source code #5368

merged 1 commit into from Dec 3, 2018


Copy link

@sjackman sjackman commented Dec 3, 2018

Source code is not required at run time.
These matches may be caused by debugging symbols.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@sjackman sjackman self-assigned this Dec 3, 2018
Copy link

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment? Otherwise 👍🏻 Thanks!

@sjackman sjackman force-pushed the bottle-ignore-source branch 2 times, most recently from 19fff2e to 8947500 Compare December 3, 2018 16:01
Ignore matches to source code, which is not required at run time.
These matches may be caused by debugging symbols.
@sjackman sjackman merged commit c89f6c8 into Homebrew:master Dec 3, 2018
@sjackman sjackman deleted the bottle-ignore-source branch December 3, 2018 17:39
@lock lock bot added the outdated PR was locked due to age label Jan 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
outdated PR was locked due to age
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants