New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottle: Ignore matches to source code #5368

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@sjackman
Copy link
Contributor

sjackman commented Dec 3, 2018

Source code is not required at run time.
These matches may be caused by debugging symbols.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@sjackman sjackman requested a review from MikeMcQuaid Dec 3, 2018

@sjackman sjackman self-assigned this Dec 3, 2018

@MikeMcQuaid
Copy link
Member

MikeMcQuaid left a comment

Can you add a comment? Otherwise 👍🏻 Thanks!

@sjackman sjackman force-pushed the sjackman:bottle-ignore-source branch 2 times, most recently from 19fff2e to 8947500 Dec 3, 2018

bottle: Ignore matches to source code
Ignore matches to source code, which is not required at run time.
These matches may be caused by debugging symbols.

@sjackman sjackman force-pushed the sjackman:bottle-ignore-source branch from 8947500 to 79b1d41 Dec 3, 2018

@sjackman sjackman merged commit c89f6c8 into Homebrew:master Dec 3, 2018

3 checks passed

codecov/patch 100% of diff hit (target 71.2%)
Details
codecov/project 71.2% (+0%) compared to 704e857
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sjackman sjackman deleted the sjackman:bottle-ignore-source branch Dec 3, 2018

@lock lock bot added the outdated label Jan 2, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.