Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link: prevent :provided_by_macos links everywhere. #5383

Merged

Conversation

MikeMcQuaid
Copy link
Member

We've not seen complaints about these and they are the default behaviour on High Sierra and Mojave so it's easier to apply them consistently everywhere.

Also, combined with Homebrew/homebrew-core#34854, simplify the linkage of *SSL.

This would have avoided Homebrew/homebrew-core#34754.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We've not seen complaints about these and they are the default behaviour
on High Sierra and Mojave so it's easier to apply them consistently
everywhere.
@MikeMcQuaid MikeMcQuaid merged commit d20f0a8 into Homebrew:master Dec 7, 2018
@MikeMcQuaid MikeMcQuaid deleted the link-provided-by-macos-consistently branch December 7, 2018 14:58
@lock lock bot added the outdated PR was locked due to age label Jan 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants