_brew | allow 'brew commands' to be cached by zsh #5388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?Hi,
Here is an update to
_brew
where the most expensive command (__brew_all_commands
) has its results cached. This results in faster (immediate?) completion. This should help people with slow machine (my mac at work is hugely slowed down by the security measures).I tried my best and used the standard mechanism; the code follows along the many available examples.
The user will have its results cached if his/her shell is configured to do so: meaning that the standard zstyle (
use-cache
) has to be set to'yes'
and that the cache will be saved by default in~/.zcompcache/brew_all_commands
(also configurable using the zstylecache-path
). The delay for cache invalidation is set to 24h completions/zsh/_brew#135. I expect no kitten to be harmed with this PR.Regarding tests, I only conducted manual checks:
~/.zcompcache/brew_all_commands
: the cache gets createdI hope you'll review it and it eventually gets accepted.
Have a great day.