New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the meaning of open source for core formula #5406

Merged
merged 1 commit into from Dec 15, 2018

Conversation

Projects
None yet
2 participants
@jasontedor
Copy link
Contributor

jasontedor commented Dec 14, 2018

This commit clarifies the meaning of "open-source" when explaining that only open source formulae are acceptable in core. In particular, the open source license must be an OSI-approved license.

Clarify the meaning of open source for core formula
This commit clarifies the meaning of "open-source" when explaining that
only open source formulae are acceptable in core. In particular, the
open source license must be an OSI-approved license.
@jasontedor

This comment has been minimized.

Copy link
Contributor

jasontedor commented Dec 14, 2018

Heya @MikeMcQuaid, following up on our discussion, I am suggesting this clarification to the docs. Would you be able to review and let me know your thoughts?

@MikeMcQuaid
Copy link
Member

MikeMcQuaid left a comment

Looks good, thanks @jasontedor!

@MikeMcQuaid MikeMcQuaid merged commit 823716e into Homebrew:master Dec 15, 2018

3 checks passed

codecov/patch Coverage not affected when comparing e5df649...d8f4ce1
Details
codecov/project 71.25% remains the same compared to e5df649
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasontedor jasontedor deleted the jasontedor:clarify-open-source branch Dec 15, 2018

@jasontedor

This comment has been minimized.

Copy link
Contributor

jasontedor commented Dec 15, 2018

Thanks @MikeMcQuaid.

@lock lock bot added the outdated label Jan 14, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jan 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.