/ brew Public
Whitelist TERMINFO environment variable #5445
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
brew stylewith your changes locally?
brew testswith your changes locally?
TERMINFOenvironment variable is used by ncurses et al to find files describing current terminal's capabilities (see e.g.
man ncurses). When the variable is filtered out, code using
ncursesdown the line gets confused if the terminal is not included in the default termcap database. An example of this is the "Cannot read termcap database; using dumb terminal settings" message described in #4527. This is written by libedit, loaded from irb, loaded from debrew. With this patch the message is not printed any more.
An alternative solution is to place termcap files under
~/.terminfoinstead. Some terminals do not do this by default, for instance Kitty.