Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: run and replace brew prune. #5467

Merged
merged 1 commit into from Jan 2, 2019

Conversation

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jan 2, 2019

It's always seemed a bit pointless to me that we have both of these commands. Given we're doing more and more to recommend (and eventually, safely, automatically run (see #4760) brew cleanup let's roll their functionality into a single command.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It's always seemed a bit pointless to me that we have both of these
commands. Given we're doing more and more to recommend (and eventually,
safely, automatically run (see #4760) `brew cleanup` let's roll their
functionality into a single command.
@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:cleanup-runs-prune branch from 1e2fa49 to 8cfcc7f Jan 2, 2019
@MikeMcQuaid MikeMcQuaid merged commit 2deacc7 into Homebrew:master Jan 2, 2019
2 checks passed
2 checks passed
@azure-pipelines
brew Build #20190102.33 succeeded
Details
coverage/coveralls First build on cleanup-runs-prune at 71.226%
Details
@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:cleanup-runs-prune branch Jan 2, 2019
aheckler added a commit to aheckler/update-all-the-things that referenced this pull request Jan 9, 2019
It's deprecated: Homebrew/brew#5467
sticklerm3 added a commit to sticklerm3/my-mac-fish-functions that referenced this pull request Jan 11, 2019
See Homebrew/brew#5467 or go to
https://brew.sh/2019/01/09/homebrew-1.9.0/ for all the changes in
homebrew 1.9.0
@lock lock bot added the outdated label Feb 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant