Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info: make --json a valid argument. #5478

Merged
merged 1 commit into from Jan 4, 2019

Conversation

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jan 3, 2019

This is already accepted so let's handle this in the logic instead.

CC @chdiza @GauthamGoli for thoughts.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
Copy link
Member Author

@MikeMcQuaid MikeMcQuaid commented Jan 3, 2019

This actually doesn't work quite as expected: brew info --json wget works but brew info wget --json does not. @GauthamGoli any thoughts?

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:info-json-default branch from bdd0477 to 829702d Jan 3, 2019
@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:info-json-default branch from 829702d to 5b836e1 Jan 4, 2019
@MikeMcQuaid
Copy link
Member Author

@MikeMcQuaid MikeMcQuaid commented Jan 4, 2019

Thanks for the help @GauthamGoli. Pushed!

@GauthamGoli
Copy link
Member

@GauthamGoli GauthamGoli commented Jan 4, 2019

@MikeMcQuaid

$ brew info --json=v3 wget
Error: invalid JSON version: v3
Please report this bug:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/cmd/info.rb:91:in `info'
/usr/local/Homebrew/Library/Homebrew/brew.rb:89:in `<main>'
This is already accepted so let's handle this in the logic instead.
@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:info-json-default branch from 5b836e1 to e3a178a Jan 4, 2019
@MikeMcQuaid
Copy link
Member Author

@MikeMcQuaid MikeMcQuaid commented Jan 4, 2019

@GauthamGoli Fixed, meant to use UsageError.

@MikeMcQuaid MikeMcQuaid merged commit 930f7b9 into Homebrew:master Jan 4, 2019
2 checks passed
2 checks passed
brew Build #20190104.14 succeeded
Details
coverage/coveralls First build on info-json-default at 71.262%
Details
@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:info-json-default branch Jan 22, 2019
@lock lock bot added the outdated label Feb 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants