Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV: default CFLAGS to bottle values. #5491

Merged
merged 1 commit into from Jan 7, 2019

Conversation

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jan 6, 2019

This reduces the deviation in compilation flags on a given OS between users and between bottling/not bottling to provide a consistent behaviour for debugging and support.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:bottle-arch-default branch from 85c7483 to 3e89026 Jan 6, 2019
This reduces the deviation in compilation flags on a given OS between
users and between bottling/not bottling to provide a consistent
behaviour for debugging and support.
@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:bottle-arch-default branch from 3e89026 to 7e13b37 Jan 6, 2019
@MikeMcQuaid MikeMcQuaid merged commit 52bea2a into Homebrew:master Jan 7, 2019
2 checks passed
2 checks passed
brew Build #20190106.28 succeeded
Details
coverage/coveralls First build on bottle-arch-default at 71.276%
Details
@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:bottle-arch-default branch Jan 7, 2019
@claui claui mentioned this pull request Jan 8, 2019
4 of 6 tasks complete
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 8, 2019
6 of 6 tasks complete
@lock lock bot added the outdated label Feb 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant