Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV: default CFLAGS to bottle values. #5491

Merged
merged 1 commit into from Jan 7, 2019

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jan 6, 2019

This reduces the deviation in compilation flags on a given OS between users and between bottling/not bottling to provide a consistent behaviour for debugging and support.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This reduces the deviation in compilation flags on a given OS between
users and between bottling/not bottling to provide a consistent
behaviour for debugging and support.
@MikeMcQuaid MikeMcQuaid merged commit 52bea2a into Homebrew:master Jan 7, 2019
@MikeMcQuaid MikeMcQuaid deleted the bottle-arch-default branch January 7, 2019 08:30
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 8, 2019
6 tasks
@lock lock bot added the outdated PR was locked due to age label Feb 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant