New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shell-Completion.md #5511

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@iandol
Copy link
Contributor

iandol commented Jan 9, 2019

iandol added a commit to iandol/homebrew-core that referenced this pull request Jan 9, 2019

Update caveat text to point to correct folder to source
See https://discourse.brew.sh/t/bash-completion-and-brew-instructions-for-setting-up-completions/3808

On both my Ubuntu and macOS brew installs, bash completions are found in `[brew --prefix]/etc/bash_completion.d` yet the caveat instructions considers `brew_completion` as a file to source, rather than source all files within the `bash_completion.d` folder. Is `bash_completion.d` where everyone else finds their completions?

Also update the main documentation @ Homebrew/brew#5511

@iandol iandol referenced this pull request Jan 9, 2019

Merged

Update caveat text to point to correct folder to source #35817

0 of 5 tasks complete

BrewTestBot added a commit to BrewTestBot/homebrew-core that referenced this pull request Jan 9, 2019

Update caveat text to point to correct folder to source
See https://discourse.brew.sh/t/bash-completion-and-brew-instructions-for-setting-up-completions/3808

On both my Ubuntu and macOS brew installs, bash completions are found in `[brew --prefix]/etc/bash_completion.d` yet the caveat instructions considers `brew_completion` as a file to source, rather than source all files within the `bash_completion.d` folder. Is `bash_completion.d` where everyone else finds their completions?

Also update the main documentation @ Homebrew/brew#5511
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jan 9, 2019

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @iandol!

@MikeMcQuaid MikeMcQuaid merged commit 04b020d into Homebrew:master Jan 9, 2019

1 check passed

coverage/coveralls First build on patch-1 at 71.454%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment