New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: skip linking formulae with already installed casks. #5613

Merged
merged 1 commit into from Jan 26, 2019

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jan 25, 2019

If you have the emacs or docker formulae and casks both
installed the formula will fail to link. Skip trying to link the formula
if the cask is already installed.

Fixes Homebrew/homebrew-core#36310.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

formula_installer: skip linking formulae with already installed casks.
If you have the `emacs` or `docker` formulae and casks both
installed the formula will fail to link. Skip trying to link the formula
if the cask is already installed.

Fixes Homebrew/homebrew-core#36310.

@MikeMcQuaid MikeMcQuaid merged commit 0670282 into Homebrew:master Jan 26, 2019

1 check passed

coverage/coveralls First build on cask-link-formula-name at 71.515%
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:cask-link-formula-name branch Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment