New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor-install: use Mavericks portable Ruby. #5624

Merged
merged 1 commit into from Jan 27, 2019

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jan 27, 2019

This is not universal so is smaller (8MB vs 12MB). It also performs 5-10% faster at:
https://rubybench.org/ruby/ruby/releases?result_type=array_sample_100k___50k

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

vendor-install: use Mavericks portable Ruby.
This is not universal so is smaller (8MB vs 12MB). It also performs
5-10% faster at:
https://rubybench.org/ruby/ruby/releases?result_type=array_sample_100k___50k

@MikeMcQuaid MikeMcQuaid merged commit ede58e8 into Homebrew:master Jan 27, 2019

1 check passed

coverage/coveralls First build on mavericks-portable-ruby at 71.465%
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:mavericks-portable-ruby branch Jan 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment