Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinstall: don't build bottles unnecessarily. #6069

Merged
merged 1 commit into from Apr 26, 2019
Merged

reinstall: don't build bottles unnecessarily. #6069

merged 1 commit into from Apr 26, 2019

Conversation

xu-cheng
Copy link
Member

Apply the same changes from #6066.

Also apply the same logics from brew upgrade to preserve
installed_as_dependency/installed_on_request settings
when reinstalling formulae.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Apply the same changes from #6066.

Also apply the same logics from `brew upgrade` to preserve
`installed_as_dependency`/`installed_on_request` settings
when reinstalling formulae.
@MikeMcQuaid
Copy link
Member

Thanks again @xu-cheng!

@MikeMcQuaid MikeMcQuaid merged commit e94cd41 into Homebrew:master Apr 26, 2019
@xu-cheng xu-cheng deleted the reinstall branch April 26, 2019 18:15
@lock lock bot added the outdated PR was locked due to age label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants