From e1a592c76c1f4084740258f5597df40d4973d670 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=B2=99=E6=BC=A0=E4=B9=8B=E5=AD=90?= Date: Mon, 7 Oct 2019 16:19:33 +0800 Subject: [PATCH 1/2] Adding the `header` option to `CurlDownloadStrategy`. It's easy to access github private resources later through specific `header` settings. e.g. ``` cask 'XXXX' do ... url "https://raw.githubusercontent.com/....", header : "Authorization: token #{ENV['HOMEBREW_GITHUB_API_TOKEN']}" ... end ``` --- Library/Homebrew/download_strategy.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb index 4735f5339e10d..c02d42b54b146 100644 --- a/Library/Homebrew/download_strategy.rb +++ b/Library/Homebrew/download_strategy.rb @@ -421,6 +421,8 @@ def _curl_args args += ["--user", meta.fetch(:user)] if meta.key?(:user) + args += ["-H", meta.fetch(:header)] if meta.key?(:header) + args end From 52511d3f7785ee3892a113e538e0bda633e18c9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=B2=99=E6=BC=A0=E4=B9=8B=E5=AD=90?= Date: Mon, 7 Oct 2019 18:56:03 +0800 Subject: [PATCH 2/2] Modify `curl`'s `header` option `-H` to `--header` --- Library/Homebrew/download_strategy.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb index c02d42b54b146..017d365c6fd48 100644 --- a/Library/Homebrew/download_strategy.rb +++ b/Library/Homebrew/download_strategy.rb @@ -421,7 +421,7 @@ def _curl_args args += ["--user", meta.fetch(:user)] if meta.key?(:user) - args += ["-H", meta.fetch(:header)] if meta.key?(:header) + args += ["--header", meta.fetch(:header)] if meta.key?(:header) args end