Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention 2 common errors for linux maintainers #6913

Merged
merged 1 commit into from Jan 9, 2020

Conversation

@dawidd6
Copy link
Member

dawidd6 commented Jan 9, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  1. "undefined reference to ..." when running gcc in test do block.
  2. Wrong cellar line.

cc @Homebrew/linux folks

@dawidd6 dawidd6 force-pushed the dawidd6:linux-gotchas-docs branch from d7c1461 to 3a938ff Jan 9, 2020
Copy link
Member

issyl0 left a comment

Thanks for doing this! Just a few wording tweaks...

docs/Homebrew-linuxbrew-core-Maintainer-Guide.md Outdated Show resolved Hide resolved
docs/Homebrew-linuxbrew-core-Maintainer-Guide.md Outdated Show resolved Hide resolved
docs/Homebrew-linuxbrew-core-Maintainer-Guide.md Outdated Show resolved Hide resolved
1. "undefined reference to ..." when running `gcc` in `test do` block.
2. Wrong cellar line.

Co-Authored-By: Issy Long <me@issyl0.co.uk>
@dawidd6 dawidd6 force-pushed the dawidd6:linux-gotchas-docs branch from d1105a2 to a2e6c12 Jan 9, 2020
@issyl0
issyl0 approved these changes Jan 9, 2020
@MikeMcQuaid MikeMcQuaid merged commit bcd6a08 into Homebrew:master Jan 9, 2020
3 checks passed
3 checks passed
tests (ubuntu-latest)
Details
tests (macOS-latest)
Details
coverage/coveralls First build on linux-gotchas-docs at 73.798%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.