Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/gist-logs: Fix bug with parsing of command-line arguments #6936
- A user reported the following error when running `brew gist-logs`, reproducible with any formula: ``` $ brew gist-logs rustup-init Error: undefined method `length' for nil:NilClass Please report this bug: https://docs.brew.sh/Troubleshooting /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/gist-logs.rb:145:in `gist_logs' /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:102:in ``` - From what I can tell, `gist_logs_args.parse` had ended up in the wrong method. The `gistify_logs` method already has `formula` (ie the formula name) passed into it. But it's the `gist_logs` method that needs to do the argument parsing. This was discovered by looking at some other recently changed ARGV => Homebrew.args code like cmd/info.