Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: Determine Linux-only formulae with `depends_on :linux` #7032

Merged

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 13, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • We used to use # tag "linux" in Homebrew/linuxbrew-core for the ~50 Linux-only formulae. As of Homebrew/linuxbrew-core@6578a4a, we're using depends_on :linux to have a consistent syntax between Linux and macOS.
  • Therefore, we have to change the search string for Linux-only formulae that determines whether or not brew bump-formula-pr deletes the bottle line.

Successfully tested with Homebrew/linuxbrew-core#19623.

- We used to use `# tag "linux"` in Homebrew/linuxbrew-core for the ~50
  Linux-only formulae. As of
  Homebrew/linuxbrew-core@6578a4a,
  we're using `depends_on :linux` to have a consistent syntax between
  Linux and macOS.
- Therefore, we have to change the search string for Linux-only formulae
  that determines whether or not `brew bump-formula-pr` deletes the bottle
  line.
@issyl0 issyl0 requested a review from dawidd6 Feb 13, 2020
@issyl0 issyl0 merged commit 516d7e8 into Homebrew:master Feb 13, 2020
3 checks passed
3 checks passed
tests (ubuntu-latest)
Details
tests (macOS-latest)
Details
coverage/coveralls First build on bump-formula-pr-new-linux-formula-indicator at 73.469%
Details
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Feb 14, 2020

Nice work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.