Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop/lines: add protobuf to whitelist #7040

Merged
merged 1 commit into from Feb 16, 2020
Merged

rubocop/lines: add protobuf to whitelist #7040

merged 1 commit into from Feb 16, 2020

Conversation

samford
Copy link
Member

@samford samford commented Feb 16, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As seen in Homebrew/homebrew-core#50295, the protobuf formula fails brew audit --strict due to having a make check step. It was suggested that I add protobuf to the whitelist since it's a library, so here we are.

@MikeMcQuaid MikeMcQuaid merged commit d0f40ed into Homebrew:master Feb 16, 2020
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @samford!

@samford samford deleted the protobuf-whitelist-build-time-checks branch February 16, 2020 19:18
@lock lock bot added the outdated PR was locked due to age label Mar 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants